Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unclaim gateway on delete #7356

Open
wants to merge 1 commit into
base: v3.32
Choose a base branch
from
Open

Unclaim gateway on delete #7356

wants to merge 1 commit into from
+39 −4

Conversation

PavelJankoski
Copy link
Contributor

Summary

Unclaim gateway on delete.

Changes

  • Include unclaiming logic in the delete-entity-header-modal component.

Testing

Steps

Try deleting a managed gateway.

Results

The gateway should be unclaimed and then deleted.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@PavelJankoski PavelJankoski added the bug Something isn't working label Oct 23, 2024
@PavelJankoski PavelJankoski added this to the Oct 2024 milestone Oct 23, 2024
@PavelJankoski PavelJankoski self-assigned this Oct 23, 2024
@PavelJankoski PavelJankoski requested a review from a team as a code owner October 23, 2024 15:05
@github-actions github-actions bot added the ui/web This is related to a web interface label Oct 23, 2024
johanstokking
johanstokking reviewed Oct 23, 2024
View reviewed changes
Copy link
Member

@johanstokking johanstokking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can't comment on the code, but do we need end-to-end tests too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanstokking johanstokking johanstokking left review comments

@mjamescompton mjamescompton Awaiting requested review from mjamescompton mjamescompton is a code owner automatically assigned from TheThingsNetwork/stack-reviewers-3

@ryaplots ryaplots Awaiting requested review from ryaplots

At least 1 approving review is required to merge this pull request.

Assignees

@PavelJankoski PavelJankoski

Labels
bug Something isn't working ui/web This is related to a web interface
Projects
None yet
Milestone
Oct 2024
Development

Successfully merging this pull request may close these issues.
2 participants
@PavelJankoski @johanstokking